Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NavView Hamburger btn and header overlap on launch in minimal mode #652

Merged
merged 6 commits into from
May 6, 2019
Merged

NavView Hamburger btn and header overlap on launch in minimal mode #652

merged 6 commits into from
May 6, 2019

Conversation

ojhad
Copy link
Contributor

@ojhad ojhad commented May 3, 2019 •
edited by jevansaks
Loading

Fixes #274

Fixed issue with DisplayModeGroup not being properly updated in the scenario when navview is first loaded in minimal mode. Due to the pane being open by default, the DisplayModeGroup visual state is not in the proper state it needs to be in when the pane is closed.

I created a new navigation view test page in order to recreate the scenario where NavigationView gets first loaded in minimal mode.

@ojhad ojhad requested a review from a team as a code owner May 3, 2019 20:53
@jevansaks jevansaks added area-NavigationView NavView control needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) labels May 3, 2019
StephenLPeters
StephenLPeters approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ojhad ojhad merged commit 59a2700 into master May 6, 2019
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label May 13, 2019
@jevansaks jevansaks removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label May 30, 2019
jevansaks pushed a commit that referenced this pull request May 30, 2019
@ojhad @jevansaks
NavView Hamburger btn and header overlap on launch in minimal mode (#652
33ea7e5 
)

* fixed hamburger overlap on launch

* fix for hamburgerbtn header overlap

* added test

* minor cleanup

* addressed comments

* fixed typo
@jevansaks jevansaks removed the needs-cherrypicktorelease PR tagged for cherry-pick to the current release branch (but not yet picked) label May 30, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.1.190606001 has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190611001 has been released which incorporates this pull request.:tada:

Handy links:

@myokeeh myokeeh mentioned this pull request Jun 12, 2019
Closed
@jevansaks jevansaks deleted the user/ojhad/hamburgerbtnheaderoverlap branch June 12, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisglein chrisglein chrisglein approved these changes

@StephenLPeters StephenLPeters StephenLPeters approved these changes

@licanhua licanhua licanhua approved these changes

Assignees
No one assigned
Labels
area-NavigationView NavView control release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NavigationView: hamburger button sometimes overlaps header in Minimal mode
6 participants
@ojhad @msft-github-bot @licanhua @StephenLPeters @chrisglein @jevansaks