Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triggering rasterization of Scroller Content after zoom operation on RS5+ #669

Merged
merged 4 commits into from
May 15, 2019

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented May 8, 2019

Fixes #541 - Scroller.Content rasterization after zoom operation.
Fixes #136 - Scroller test failure.

The Scroller.Content was not re-rasterizing after a zoom operation, causing the rendering to be blurry. The solution here is to stop the zoom factor expression animation targeting the UIElement.Scale façade property until a batch update was sent to Composition, then re-start the animation. This causes a rasterization.

I added a Scroller test hook to detect animation starts and stops in general, and those zoom factor animation interruptions in particular. All the view change API tests are now at the lookout for those private test hook notifications.

Also fixed:

  • a typo in ScrollerOperation ScrollerTests.StartScrollBy, and re-enabled two Scroller tests.
  • a bug in Scroller::ValuesChanged so that a non-animated view change is declared completed as soon as the ValuesChanged event is raised.

RBrid added 2 commits May 8, 2019 13:15
Issue#541 - Scroller.Content rasterization after zoom operation.
Issue#136 - Scroller test failure.
@RBrid RBrid requested a review from a team May 8, 2019 20:36
@RBrid RBrid self-assigned this May 8, 2019
@RBrid RBrid requested a review from StephenLPeters May 14, 2019 01:00
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@adrientetar
Copy link

@jevansaks Do you plan to put out a new prerelease? I would like to test the improvements in this PR.

@jevansaks jevansaks deleted the user/rbrid/Scroller541 branch June 3, 2019 04:10
@jevansaks
Copy link
Member

@jevansaks Do you plan to put out a new prerelease? I would like to test the improvements in this PR.

Thanks for asking! Yes we're planning one for this week, we were just waiting for a couple of in-progress ScrollViewer and TabView features.

@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Jun 10, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190611001 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Scrolling release note PR that we want to call out in the next release summary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScrollViewer / Scroller doesn't re-rasterize the content after a zoom Multiple unreliable Scroller tests
5 participants