Enable file version info in build #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llongley
requested changes
May 23, 2019
jevansaks
added
needs-cherrypicktorelease
|
/azp run WinUI-Public-Tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
llongley
approved these changes
May 23, 2019
jevansaks
removed
the
needs-cherrypicktorelease
jevansaks
pushed a commit
that referenced
this pull request
May 30, 2019
When we switched over from Package ES builds to regular Azure DevOps builds, we lost some functionality in Package ES that was automatically setting the version info in the built dll. This version info is used to determine what version of WinUI a given app is using. This PR updates the build to set the version information. When building locally, the version information is taken from version.props (currently defined to be 2.2.0.0). When building in Azure Pipelines, the third and forth component of this version is overridden based on the date (YY, MM, DD) and the pipeline's revision number (RRR) so that we get version 2.2.YYMM.DDRRR This closely matches the nupkg which is versioned as: 2.2.YYMMDDRRR
jevansaks
removed
the
needs-cherrypicktorelease
|
🎉 Handy links: |
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we switched over from Package ES builds to regular Azure DevOps builds, we lost some functionality in Package ES that was automatically setting the version info in the built dll.
This version info is used to determine what version of WinUI a given app is using.
This PR updates the build to set the version information.
When building locally, the version information is taken from version.props (currently defined to be 2.2.0.0). When building in Azure Pipelines, the third and forth component of this version is overridden based on the date (YY, MM, DD) and the pipeline's revision number (RRR) so that we get version 2.2.YYMM.DDRRR
This closely matches the nupkg which is versioned as:
2.2.YYMMDDRRR