Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix for uniformgrid property changed handler #846

Merged
merged 2 commits into from
Jun 12, 2019
Merged

fix for uniformgrid property changed handler #846

merged 2 commits into from
Jun 12, 2019

Conversation

ranjeshj
Copy link
Contributor

Typo '=' instead of '=='
Fixes #788

@ranjeshj ranjeshj requested a review from a team June 11, 2019 05:01
@jevansaks jevansaks added the release note PR that we want to call out in the next release summary label Jun 11, 2019
chrisglein
chrisglein approved these changes Jun 11, 2019
View reviewed changes
dev/Repeater/APITests/FlowLayoutTests.cs Outdated Show resolved Hide resolved
dev/Repeater/APITests/FlowLayoutTests.cs Show resolved Hide resolved
@ranjeshj ranjeshj merged commit 1d603c3 into master Jun 12, 2019
@msft-github-bot
Copy link
Collaborator

🎉Microsoft.UI.Xaml v2.2.190702001-prerelease has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Jul 2, 2019
Closed
@anawishnoff anawishnoff deleted the user/ranjeshj/uniformgridissue branch November 3, 2020 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrisglein chrisglein chrisglein approved these changes

Assignees
No one assigned
Labels
release note PR that we want to call out in the next release summary
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UniformGridLayout uses assignment instead of comparison
4 participants
@ranjeshj @msft-github-bot @chrisglein @jevansaks