Scroller: Fixing layout of partially stretched Content #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dth or ExtentHeight is incorrect when Content stretches partially.
jevansaks
added
the
release note
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address a bug mentioned in Issue #829.
When using a Viewbox as the Content of a Scroller, in Stretched alignment mode, the computed Scroller.ExtentWidth or Scroller.ExtentHeight could be wrong. In the reported case, the Viewbox contained an Image that was partially stretched to preserve its aspect ratio. The Scroller viewport size cannot assumed to be the final extent. When the stretched Content renders smaller than the viewport, it is re-arranged using the smaller rendering size so it is positioned as expected within the viewport, and the extent is corrected accordingly.
Expanded the MUXControlsTestApp and added a new TAEF test to better cover these scenarios.