Make Vite sample code Firefox compatible #2991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current sample code for "Using Vite" works fine in Chrome, but causes errors in Firefox: `Error: import declarations may only appear at top level of a module` In addition to many errors logged to the console, this also causes subtle bugs in Firefox (e.g. the highlighting in the diff editor didn't work). The problem appears to be that Firefox requires an explicit `type: module` for the web workers. The revised implementation for Vite takes this into account and has been tested successfully in Chrome and Firefox.
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current sample code for "Using Vite" works fine in Chrome, but causes errors in Firefox:
Error: import declarations may only appear at top level of a moduleIn addition to many errors logged to the console, this also causes subtle bugs in Firefox (e.g. the highlighting in the diff editor didn't work).
The problem appears to be that Firefox requires an explicit
type: modulefor the web workers.The revised implementation for Vite takes this into account and has been tested successfully in Chrome and Firefox.