Skip to content
This repository has been archived by the owner on Nov 5, 2021. It is now read-only.

Add Swift fileprivate access modifier #144

Merged
merged 2 commits into from
Jul 4, 2021
Merged

Add Swift fileprivate access modifier #144

merged 2 commits into from
Jul 4, 2021

Conversation

AbrilRBS
Copy link
Contributor

@AbrilRBS AbrilRBS commented Jul 3, 2021

As per https://docs.swift.org/swift-book/LanguageGuide/AccessControl.html#ID5, this PR adds the missing fileprivate access modifier to the Swift definition

This should close microsoft/monaco-editor#2560

@hediet hediet merged commit 0b018cd into microsoft:main Jul 4, 2021
@hediet
Copy link
Member

hediet commented Jul 4, 2021

Thank you very much for your PR!

@hediet hediet added this to the July 2021 milestone Jul 4, 2021
@AbrilRBS AbrilRBS deleted the swift-fileprivate branch July 4, 2021 10:31
@hediet hediet modified the milestones: July 2021, June 2021 Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Swift fileprivate access modifier
2 participants