Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helper Complete Jobs #4585

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Add Helper Complete Jobs #4585

merged 2 commits into from
Oct 1, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Oct 1, 2024

Description

Leverages re-actors/alls-green to create a job that passes/fails if all the dependent jobs succeed. This makes it easier to onboard branch rules to only allow the PR to complete once these pass.

I didn't add this for everything (yet) as we still have some flaky BVT and stress tests.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks enabled auto-merge (squash) October 1, 2024 12:14
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.60%. Comparing base (0b70805) to head (5fe0b26).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4585      +/-   ##
==========================================
- Coverage   86.98%   86.60%   -0.39%     
==========================================
  Files          56       56              
  Lines       17354    17354              
==========================================
- Hits        15096    15030      -66     
- Misses       2258     2324      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks merged commit 01e4ae3 into main Oct 1, 2024
477 of 479 checks passed
@nibanks nibanks deleted the github-action-complete branch October 1, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants