add barrier missing between producer submit and needpoke check #4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
previously approved these changes
Oct 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4593 +/- ##
==========================================
- Coverage 86.94% 86.66% -0.29%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 15089 15040 -49
- Misses 2265 2314 +49 ☔ View full report in Codecov by Sentry. |
csujedihy
reviewed
Oct 4, 2024
csujedihy
approved these changes
Oct 7, 2024
nibanks
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
I noticed MsQuic is missing the mandatory (on x64) barrier between submitting TX producer entries and checking the TX ring for the NeedPoke flag. If these operations get reordered, pokes could be missed.
Testing
Do any existing tests cover this change? Are new tests needed?
CI.
Documentation
Is there any documentation impact for this change?
No.