Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust: Rename Error to Status #4791

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

youyuanwu
Copy link
Contributor

Description

Originally Error was crated to wrap the quic status code in rust Result<(),Error>, but it creates confusions with the msquic naming. In callback events, "status" fields are used and Error in status fields looks odd.
Using StatusCode in callback events has other problems since StatusCode enum does not capture all possible returns from msquic. See #4786.
This PR renames Error to Status, and it will be used in callback events. This is also consistent with the StatusCode rename completed previously in #4765

Testing

Existing tests.

Documentation

NA

@youyuanwu youyuanwu marked this pull request as ready for review February 2, 2025 20:34
@youyuanwu youyuanwu requested a review from a team as a code owner February 2, 2025 20:34
Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.70%. Comparing base (ba795e0) to head (6167ec5).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4791      +/-   ##
==========================================
- Coverage   87.38%   86.70%   -0.69%     
==========================================
  Files          56       56              
  Lines       17400    17400              
==========================================
- Hits        15205    15086     -119     
- Misses       2195     2314     +119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant