Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong instruction in sample.md #4792

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Conversation

TKONIY
Copy link
Contributor

@TKONIY TKONIY commented Feb 2, 2025

Delete the "{}" which makes the ip unable to identified

Description

-target:{127.0.0.1} will result in error.

Testing

None

Documentation

Modified the sample.md

Delete the "{}" which makes the ip unable to identified
@TKONIY TKONIY requested a review from a team as a code owner February 2, 2025 23:29
Copy link

codecov bot commented Feb 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.77%. Comparing base (ad4a32e) to head (f8777f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4792      +/-   ##
==========================================
+ Coverage   85.95%   86.77%   +0.81%     
==========================================
  Files          56       56              
  Lines       17400    17400              
==========================================
+ Hits        14956    15098     +142     
+ Misses       2444     2302     -142     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TKONIY
Copy link
Contributor Author

TKONIY commented Feb 3, 2025

Hi @nibanks, do you know how to fix this CI error?
image

@nibanks nibanks added the external Proposed by non-MSFT label Feb 3, 2025
@nibanks
Copy link
Member

nibanks commented Feb 3, 2025

Hi @nibanks, do you know how to fix this CI error? image

Don't worry about it. We've got a few small things we need to address.

@nibanks nibanks merged commit 3b212a0 into microsoft:main Feb 3, 2025
481 of 484 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external Proposed by non-MSFT
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants