Incident#567732673 - Add provision to set SQLServerBulkCopy options in PreparedStatement #2555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machavan
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2555 +/- ##
============================================
+ Coverage 51.01% 51.29% +0.28%
- Complexity 3921 3968 +47
============================================
Files 147 147
Lines 33483 33669 +186
Branches 5609 5628 +19
============================================
+ Hits 17081 17272 +191
+ Misses 13991 13980 -11
- Partials 2411 2417 +6 ☔ View full report in Codecov by Sentry. |
machavan
requested review from
codewatchzen,
lilgreenbird,
divang,
Jeffery-Wasty,
David-Engel and
tkyc
…faultsKeepIdentity and bulkCopyOptionDefaultsTableLock
|
Added tests for all the options in BatchExecutionWithBCOptionsTest |
tkyc
previously approved these changes
Jan 6, 2025
divang
reviewed
Jan 7, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopyOptions.java
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDataSource.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDriver.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
...est/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBCOptionsTest.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
...est/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBCOptionsTest.java
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
...est/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBCOptionsTest.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
...est/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBCOptionsTest.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Jan 7, 2025
...est/java/com/microsoft/sqlserver/jdbc/preparedStatement/BatchExecutionWithBCOptionsTest.java
Outdated
Show resolved
Hide resolved
divang
previously approved these changes
Jan 8, 2025
-Since the change has added connection string options for setting various bulk copy options, this non-standard API is not needed.
divang
previously approved these changes
Jan 13, 2025
David-Engel
reviewed
Jan 13, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerConnection.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerResource.java
Outdated
Show resolved
Hide resolved
…Lock, internalTrnsaction, encrptedValue options
machavan
commented
Jan 17, 2025
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerPreparedStatement.java
Show resolved
Hide resolved
tkyc
approved these changes
Jan 20, 2025
Jeffery-Wasty
approved these changes
Jan 20, 2025
David-Engel
approved these changes
Jan 23, 2025
|
ADO pipeline is green post merging this changeset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add provision to set SQLServerBulkCopyOptions in PreparedStatement via
-new connection string options
-a new method setBulkCopyOptions
Testing: