-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MockHiiLib, MockShellLib, MockHiiDatabase protocol #1248
Merged
apop5
merged 3 commits into
microsoft:dev/202405
from
v-bhavanisu:personal/bhavani/MockShellLibMockHiiLibMockHiiDatabase
Jan 8, 2025
Merged
Added MockHiiLib, MockShellLib, MockHiiDatabase protocol #1248
apop5
merged 3 commits into
microsoft:dev/202405
from
v-bhavanisu:personal/bhavani/MockShellLibMockHiiLibMockHiiDatabase
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
Does not have a functional impact
type:backport
Backport changes in a dev branch PR to its release branch.
labels
Jan 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1248 +/- ##
==============================================
- Coverage 1.60% 1.60% -0.01%
==============================================
Files 1377 1377
Lines 359246 359259 +13
Branches 5524 5524
==============================================
Hits 5760 5760
- Misses 353379 353392 +13
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
VivianNK
approved these changes
Jan 7, 2025
apop5
approved these changes
Jan 8, 2025
ProjectMuBot
pushed a commit
that referenced
this pull request
Jan 8, 2025
## Description Added MockHiiLib, MockShellLib, MockHiiDatabase protocol to be used by GoogleTests For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [X] Backport to release branch? ## How This Was Tested Consumed these mocks in Googletests of other repos and build successful ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
type:backport
Backport changes in a dev branch PR to its release branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added MockHiiLib, MockShellLib, MockHiiDatabase protocol to be used by GoogleTests
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Consumed these mocks in Googletests of other repos and build successful
Integration Instructions
N/A