Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Non-MM Supervisor Standalone MM X64 Binary #113

Merged

Conversation

makubacki
Copy link
Member

@makubacki makubacki commented Dec 10, 2024

Description

Closes #111

Builds a Standalone MM binary that can be used with StandaloneMmPkg as opposed to the MmSupervisorPkg.

To provide forward looking clarity, the MM Supervisor instance is renamed to include "MM Supervisor" when referenced. It is configured in platform DSCs using the following macros:

  • STANDALONEMM_MMSUPV_CRYPTO_SERVICES
  • STANDALONEMM_MMSUPV_CRYPTO_ARCH

That makes this a breaking change. All platforms using the MM Supervisor Standalone MM binaries must update their platforms to use the MM Supervisor instance of the binary from this change forward.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

  • Local build and bundle
  • Integration on a X64 MM Supervisor Standalone MM platform
  • Integration on a X64 non-MM Supervisor Standalone MM platform
  • Server build, push to NuGet feed, platform pull from NuGet feed

Integration Instructions

If the platform uses the MM Supervisor based Standalone MM environment (MmSupervisorPkg), it should set the STANDALONEMM_MMSUPV_CRYPTO_SERVICES and STANDALONEMM_MMSUPV_CRYPTO_ARCH values in the platform DSC. If the platform uses the conventional Standalone MM environment (StandaloneMmPkg), it should use the STANDALONEMM_CRYPTO_SERVICES and STANDALONEMM_CRYPTO_ARCH values`.

Note that the MM Supervisor previously used the STANDALONEMM_CRYPTO_* macros. MM Supervisor platforms must update to the MM Supervisor binaries in this release.

@makubacki makubacki added type:feature-request A new feature proposal type:design-change A new proposal or modification to a feature design labels Dec 10, 2024
@makubacki makubacki self-assigned this Dec 10, 2024
@github-actions github-actions bot added language:python Pull requests that update Python code impact:breaking-change Requires integration attention type:documentation Improvements or additions to documentation labels Dec 10, 2024
@makubacki makubacki force-pushed the add_non_supv_standalone_mm branch from e7d47c5 to 2d493a5 Compare December 10, 2024 19:27
@makubacki
Copy link
Member Author

CI is dependent on Fix OpensslPkg CI.

@makubacki makubacki force-pushed the add_non_supv_standalone_mm branch from 2d493a5 to 1a32ef3 Compare December 10, 2024 19:55
@makubacki makubacki force-pushed the add_non_supv_standalone_mm branch 2 times, most recently from 793842a to 080cd09 Compare December 10, 2024 23:30
@makubacki makubacki force-pushed the add_non_supv_standalone_mm branch from 080cd09 to a61b8b5 Compare December 11, 2024 17:03
Builds a Standalone MM binary that can be used with StandaloneMmPkg
as opposed to the MmSupervisorPkg.

To provide forward looking clarity, the MM Supervisor instance is
renamed to include "MM Supervisor" when referenced. It is configured
in platform DSCs using the following macros:

- `STANDALONEMM_MMSUPV_CRYPTO_SERVICES`
- `STANDALONEMM_MMSUPV_CRYPTO_ARCH`

That makes this a breaking change. All platforms using the MM
Supervisor Standalone MM binaries must update their platforms
to use the MM Supervisor instance of the binary from this change
forward.

Signed-off-by: Michael Kubacki <[email protected]>
Adds a check in the FDF to verify the expected MM Services are opted
into per the FDF included in the platform.

Signed-off-by: Michael Kubacki <[email protected]>
@makubacki makubacki force-pushed the add_non_supv_standalone_mm branch from 6403fae to 4aeafc7 Compare December 13, 2024 21:31
@makubacki makubacki enabled auto-merge (rebase) December 13, 2024 21:35
@makubacki makubacki merged commit f0b21fb into microsoft:release/202311 Dec 13, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:breaking-change Requires integration attention language:python Pull requests that update Python code type:design-change A new proposal or modification to a feature design type:documentation Improvements or additions to documentation type:feature-request A new feature proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add Non-MM Supervisor Standalone MM X64 Binaries
4 participants