-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Non-MM Supervisor Standalone MM X64 Binary #113
Merged
makubacki
merged 2 commits into
microsoft:release/202311
from
makubacki:add_non_supv_standalone_mm
Dec 13, 2024
Merged
Add Non-MM Supervisor Standalone MM X64 Binary #113
makubacki
merged 2 commits into
microsoft:release/202311
from
makubacki:add_non_supv_standalone_mm
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
added
type:feature-request
A new feature proposal
type:design-change
A new proposal or modification to a feature design
labels
Dec 10, 2024
github-actions
bot
added
language:python
Pull requests that update Python code
impact:breaking-change
Requires integration attention
type:documentation
Improvements or additions to documentation
labels
Dec 10, 2024
makubacki
force-pushed
the
add_non_supv_standalone_mm
branch
from
December 10, 2024 19:27
e7d47c5
to
2d493a5
Compare
CI is dependent on Fix OpensslPkg CI. |
makubacki
force-pushed
the
add_non_supv_standalone_mm
branch
from
December 10, 2024 19:55
2d493a5
to
1a32ef3
Compare
apop5
approved these changes
Dec 10, 2024
makubacki
force-pushed
the
add_non_supv_standalone_mm
branch
2 times, most recently
from
December 10, 2024 23:30
793842a
to
080cd09
Compare
5 tasks
kenlautner
approved these changes
Dec 11, 2024
Javagedes
approved these changes
Dec 11, 2024
makubacki
force-pushed
the
add_non_supv_standalone_mm
branch
from
December 11, 2024 17:03
080cd09
to
a61b8b5
Compare
Builds a Standalone MM binary that can be used with StandaloneMmPkg as opposed to the MmSupervisorPkg. To provide forward looking clarity, the MM Supervisor instance is renamed to include "MM Supervisor" when referenced. It is configured in platform DSCs using the following macros: - `STANDALONEMM_MMSUPV_CRYPTO_SERVICES` - `STANDALONEMM_MMSUPV_CRYPTO_ARCH` That makes this a breaking change. All platforms using the MM Supervisor Standalone MM binaries must update their platforms to use the MM Supervisor instance of the binary from this change forward. Signed-off-by: Michael Kubacki <[email protected]>
Adds a check in the FDF to verify the expected MM Services are opted into per the FDF included in the platform. Signed-off-by: Michael Kubacki <[email protected]>
makubacki
force-pushed
the
add_non_supv_standalone_mm
branch
from
December 13, 2024 21:31
6403fae
to
4aeafc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:breaking-change
Requires integration attention
language:python
Pull requests that update Python code
type:design-change
A new proposal or modification to a feature design
type:documentation
Improvements or additions to documentation
type:feature-request
A new feature proposal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #111
Builds a Standalone MM binary that can be used with StandaloneMmPkg as opposed to the MmSupervisorPkg.
To provide forward looking clarity, the MM Supervisor instance is renamed to include "MM Supervisor" when referenced. It is configured in platform DSCs using the following macros:
STANDALONEMM_MMSUPV_CRYPTO_SERVICES
STANDALONEMM_MMSUPV_CRYPTO_ARCH
That makes this a breaking change. All platforms using the MM Supervisor Standalone MM binaries must update their platforms to use the MM Supervisor instance of the binary from this change forward.
How This Was Tested
Integration Instructions
If the platform uses the MM Supervisor based Standalone MM environment (
MmSupervisorPkg
), it should set theSTANDALONEMM_MMSUPV_CRYPTO_SERVICES
andSTANDALONEMM_MMSUPV_CRYPTO_ARCH
values in the platform DSC. If the platform uses the conventional Standalone MM environment (StandaloneMmPkg
), it should use theSTANDALONEMM_CRYPTO_SERVICES
andSTANDALONEMM_CRYPTO_ARCH
values`.Note that the MM Supervisor previously used the
STANDALONEMM_CRYPTO_*
macros. MM Supervisor platforms must update to the MM Supervisor binaries in this release.