SetupDataPkg/ConfigKnobShimLib: Correct unit test compilation errors. #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Checking previous pipelines, these tests were not compiled due to the above mentioned bug.
github-actions
bot
added
the
impact:non-functional
kenlautner
approved these changes
Jun 20, 2024
os-d
approved these changes
Jun 20, 2024
Merged
5 tasks
apop5
added a commit
that referenced
this pull request
Jun 24, 2024
… and fix unit test. (#371) ## Description Commit #369 erroneously removed the implementation for GetConfigKnobOverride from ConfigKnobShimPeiLib. Adding back the implementation to PEI and fixing the unit test to correctly work, in the same fashion as Dxe/MM versions. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Mu Oem sample was failing with an unresolved external GetConfigKnobOverride for X64 PEI. After making this change, the unresolved external was resolved. ## Integration Instructions N/A
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jul 1, 2024
Introduces 13 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/8ef6371686e7d112aa057f314925f012c4ccdae8">8ef637</a> pip: bump pytest from 8.2.1 to 8.2.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/360">#360</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/7a3ae631a79584e40c4b575e2d8400c1a44df902">7a3ae6</a> pip: bump edk2-pytool-library from 0.21.5 to 0.21.6 (<a href="https://github.com/microsoft/mu_feature_config/pull/361">#361</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/f6c613ba840996ca7291aef822562a3d1bb648c4">f6c613</a> SetupDataPkg/ConfigKnobShimLib: Correct unit test compilation errors. (<a href="https://github.com/microsoft/mu_feature_config/pull/369">#369</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/28768f9a0b448796b2f26713f1aad2419e50c7bd">28768f</a> pip: bump edk2-pytool-extensions from 0.27.5 to 0.27.6 (<a href="https://github.com/microsoft/mu_feature_config/pull/363">#363</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/c96c22ba1a7636d66110d5a2a485b8a1abc670bd">c96c22</a> pip: bump edk2-pytool-library from 0.21.6 to 0.21.7 (<a href="https://github.com/microsoft/mu_feature_config/pull/364">#364</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/482fa2804c4c03b0758a9b131a060d649e1b4074">482fa2</a> pip: bump flake8 from 7.0.0 to 7.1.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/367">#367</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/ea90da6990711eea485402910a80842eacc4e28e">ea90da</a> Switch to using 202311 branchs of required repos instead of 202302 (<a href="https://github.com/microsoft/mu_feature_config/pull/370">#370</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/da7fa852554e50e29a61551075b77a208f804c63">da7fa8</a> SetupDataPkg/ConfigKnobShimPeiLib: Revert ConfigKnobShimPeiLib change and fix unit test. (<a href="https://github.com/microsoft/mu_feature_config/pull/371">#371</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/ae0f15ad835f8dab6c93fc0052f4ca30abf7ca19">ae0f15</a> pip: bump edk2-pytool-library from 0.21.7 to 0.21.8 (<a href="https://github.com/microsoft/mu_feature_config/pull/372">#372</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/41fd60f624099dffcc4d1e9ef36f1232b7ddf3f9">41fd60</a> SetupDataPkg/Tools/setup.py: Expand script to publish binaries for ReadUefiVarsToConfVarList, WriteConfVarListToUefiVars. (<a href="https://github.com/microsoft/mu_feature_config/pull/368">#368</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/e21d89dd19d04294a1e7d5cfcc694bee626448b7">e21d89</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/373">#373</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/11f63c34aca9b1365a48662c1acfb45ee08e7516">11f63c</a> Required changes to KnobService and XML Schema to enable per-library header definitions and XML merging (<a href="https://github.com/microsoft/mu_feature_config/pull/357">#357</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/50ecba23b26d41e4c784233f29ed1a5d5f97fa5e">50ecba</a> Add Multiple Config Environment Build Support (<a href="https://github.com/microsoft/mu_feature_config/pull/374">#374</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Unit tests started failing due to compilation errors. This stemmed from a bug fixed in microsoft/mu_basecore#891. Once this bug was fixed,
the unit tests starting to be compiled which blocked pipelines.
Checking previous pipelines, these tests were not compiled due to the above mentioned bug.
Once the fix was cherry picked back into basecore 202302, it started blocking the pipelines.
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Ran CI locally and resolved issues.
Integration Instructions
N/A