IpmiFeaturePkgPkg: apply cpp uncrustify changes #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #197 +/- ##
===========================================
- Coverage 26.04% 13.41% -12.63%
===========================================
Files 43 43
Lines 3195 2870 -325
Branches 270 270
===========================================
- Hits 832 385 -447
+ Misses 2357 2348 -9
- Partials 6 137 +131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Dec 20, 2023
makubacki
approved these changes
Dec 20, 2023
apop5
approved these changes
Dec 21, 2023
VivianNK
force-pushed
the
vnowkakeane/uncrustify_cpp
branch
from
4eb2d39 to
d38a8ae
Compare
VivianNK
added a commit
to microsoft/mu_basecore
that referenced
this pull request
Dec 22, 2023
## Description
Cherry pick uncrustify changes for cpp from edk2 and apply them to
relevant files.
- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
flow, or firmware?
- Examples: Crypto algorithm change, buffer overflow fix, parameter
validation improvement, ...
- [x] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
in build or boot behavior?
- Implements new uncrustify standard that needs to be applied to all
.cpp files and some cpp-related .h files(GoogleTests). Will need to
update the following repos:
- mu feature config (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_config#291)
- mu feature ipmi (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_ipmi#197)
- mu tiano plus [Draft
PR](microsoft/mu_tiano_plus#215)
- [ ] Includes tests?
- **Tests** - Does the change include any explicit test code?
- Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
on an a separate Web page, ...
## How This Was Tested
Local CI build
## Integration Instructions
WIll need to have up to date mu_tiano_plus branch once merged.
---------
Signed-off-by: Vivian Nowka-Keane <[email protected]>
kenlautner
pushed a commit
to microsoft/mu_basecore
that referenced
this pull request
Jan 19, 2024
Cherry pick uncrustify changes for cpp from edk2 and apply them to
relevant files.
- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
flow, or firmware?
- Examples: Crypto algorithm change, buffer overflow fix, parameter
validation improvement, ...
- [x] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
in build or boot behavior?
- Implements new uncrustify standard that needs to be applied to all
.cpp files and some cpp-related .h files(GoogleTests). Will need to
update the following repos:
- mu feature config (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_config#291)
- mu feature ipmi (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_ipmi#197)
- mu tiano plus [Draft
PR](microsoft/mu_tiano_plus#215)
- [ ] Includes tests?
- **Tests** - Does the change include any explicit test code?
- Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
on an a separate Web page, ...
Local CI build
WIll need to have up to date mu_tiano_plus branch once merged.
---------
Signed-off-by: Vivian Nowka-Keane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating Mu projects to apply uncrusty formatting for Cpp files, config updated upstream in edk2 tianocore/edk2#4957 .
Config will be updated in mu_basecore microsoft/mu_basecore#609.
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Local CI build
Integration Instructions
N/A