add update trialNum and fix bugs (#261)

microsoft · Oct 23, 2018 · ac5fda4 · ac5fda4
1 parent 30e2352
commit ac5fda4
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 16 deletions.
diff --git a/tools/nnicmd/nnictl.py b/tools/nnicmd/nnictl.py
@@ -66,6 +66,10 @@ def parse_args():
     parser_updater_duration.add_argument('--id', '-i', dest='id', help='the id of experiment')
     parser_updater_duration.add_argument('--value', '-v', required=True)
     parser_updater_duration.set_defaults(func=update_duration)
+    parser_updater_trialnum = parser_updater_subparsers.add_parser('trialnum', help='update maxtrialnum')
+    parser_updater_trialnum.add_argument('--id', '-i', dest='id', help='the id of experiment')
+    parser_updater_trialnum.add_argument('--value', '-v', required=True)
+    parser_updater_trialnum.set_defaults(func=update_trialnum)
 
     #parse stop command
     parser_stop = subparsers.add_parser('stop', help='stop the experiment')

diff --git a/tools/nnicmd/updater.py b/tools/nnicmd/updater.py
@@ -25,6 +25,7 @@
 from .url_utils import experiment_url
 from .config_utils import Config
 from .common_utils import get_json_content
+from .nnictl_utils import get_experiment_port
 
 def validate_digit(value, start, end):
     '''validate if a digit is valid'''
@@ -74,28 +75,36 @@ def update_experiment_profile(args, key, value):
 def update_searchspace(args):
     validate_file(args.filename)
     content = load_search_space(args.filename)
-    if update_experiment_profile(args, 'searchSpace', content):
-        print('INFO: update %s success!' % 'searchSpace')
-    else:
-        print('ERROR: update %s failed!' % 'searchSpace')
+    args.port = get_experiment_port(args)
+    if args.port is not None:
+        if update_experiment_profile(args, 'searchSpace', content):
+            print('INFO: update %s success!' % 'searchSpace')
+        else:
+            print('ERROR: update %s failed!' % 'searchSpace')
 
 def update_concurrency(args):
     validate_digit(args.value, 1, 1000)
-    if update_experiment_profile(args, 'trialConcurrency', int(args.value)):
-        print('INFO: update %s success!' % 'concurrency')
-    else:
-        print('ERROR: update %s failed!' % 'concurrency')
+    args.port = get_experiment_port(args)
+    if args.port is not None:
+        if update_experiment_profile(args, 'trialConcurrency', int(args.value)):
+            print('INFO: update %s success!' % 'concurrency')
+        else:
+            print('ERROR: update %s failed!' % 'concurrency')
 
 def update_duration(args):
     validate_digit(args.value, 1, 999999999)
-    if update_experiment_profile(args, 'maxExecDuration', int(args.value)):
-        print('INFO: update %s success!' % 'duration')
-    else:
-        print('ERROR: update %s failed!' % 'duration')
+    args.port = get_experiment_port(args)
+    if args.port is not None:
+        if update_experiment_profile(args, 'maxExecDuration', int(args.value)):
+            print('INFO: update %s success!' % 'duration')
+        else:
+            print('ERROR: update %s failed!' % 'duration')
 
 def update_trialnum(args):
     validate_digit(args.value, 1, 999999999)
-    if update_experiment_profile('maxTrialNum', int(args.value)):
-        print('INFO: update %s success!' % 'trialnum')
-    else:
-        print('ERROR: update %s failed!' % 'trialnum')
+    args.port = get_experiment_port(args)
+    if args.port is not None:
+        if update_experiment_profile(args, 'maxTrialNum', int(args.value)):
+            print('INFO: update %s success!' % 'trialnum')
+        else:
+            print('ERROR: update %s failed!' % 'trialnum')