Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Web UI does not support search for a specific Trial #211

Closed
scarlett2018 opened this issue Oct 15, 2018 · 3 comments
Closed

Web UI does not support search for a specific Trial #211

scarlett2018 opened this issue Oct 15, 2018 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers nnidev

Comments

@scarlett2018
Copy link
Member

I ran an experiment, and it failed with an "Error" status. After check the log, I got info about few trial did not successfully got the status. I got the trial id, but the trial table does not support search.

@scarlett2018 scarlett2018 added enhancement New feature or request good first issue Good for newcomers labels Oct 15, 2018
@yds05 yds05 added this to the 2018 Nov Release milestone Nov 27, 2018
@dahuang37
Copy link
Contributor

Hi, I would like to take on this feature. I am new to typescript but had done node and react before. I don't know exactly how I will implement this yet (will be reading the source code and docs on how the data is passed). Is there any recommended reading or parts of source code I should look into?
Thanks!

@scarlett2018
Copy link
Member Author

@yhung119 - Thank you for the attention to our project and glad you are interested in contributing to it.

To start contributing, you can follow up with our contribution guideline: https://github.com/Microsoft/nni/wiki/How-To-Contribute.

For this individual item, @lvybriage had just implemented the support for search trial by NO. the corresponding codes are at
https://github.com/Microsoft/nni/blob/v0.4/src/webui/src/components/TrialsDetail.tsx#L204
line 204-229 & line 287-299

Please add the support for "trial id" and submit your PR. Looking forward for your codes and inputs.

Best Regards,
Scarlett

@yds05
Copy link
Contributor

yds05 commented Dec 19, 2018

Resolved. Close.

@yds05 yds05 closed this as completed Dec 19, 2018
SparkSnail added a commit that referenced this issue May 18, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
merge master
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers nnidev
Projects
None yet
Development

No branches or pull requests

4 participants