This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
change quniform/qloguniform style in GridSearch to conform with other tuners #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Aug 1, 2019
| Note that q should be at least 2. | ||
| It will be sampled in a way that the first sampled value is 'low', and each of the following values is (high-low)/q larger that the value in front of it. | ||
| Type 'quniform' will receive three values [low, high, q], where [low, high] specifies a range and 'q' specifies the interval | ||
| It will be sampled in a way that the first sampled value is 'low', and each of the following values is 'interval' larger that the value in front of it. |
QuanluZhang
reviewed
Aug 1, 2019
| if param_type == 'qloguniform': | ||
| param_value[:2] = np.log(param_value[:2]) | ||
| return list(np.exp(self._parse_quniform(param_value))) | ||
| if param_type in ['quniform', 'qloguniform']: |
There was a problem hiding this comment.
cannot deal with quniform and qloguniform in the same way
There was a problem hiding this comment.
what's the difference ?
|
please update Grid Search in BuiltinTuner.md |
updated |
|
new modif:
|
QuanluZhang
reviewed
Aug 1, 2019
|
|
||
| Type 'qloguniform' behaves like 'quniform' except that it will first change the range to [log(low), log(high)] | ||
| and sample and then change the sampled value back. | ||
| Type 'randint' gives all possible intergers in range(low, high). Note that 'high' is not included. |
There was a problem hiding this comment.
range(low, high) => [low, high), more clear?
|
looks good |
QuanluZhang
approved these changes
Aug 1, 2019
xuehui1991
approved these changes
Aug 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #1335