This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Refactor get_current_parameter to avoid using trial._params #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
requested review from
chicm-ms,
liuzhe-lz,
yds05,
SparkSnail and
leckie-chn
and removed request for
leckie-chn,
SparkSnail and
chicm-ms
chicm-ms
approved these changes
Aug 21, 2019
suiguoxin
approved these changes
Aug 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, there are a few usage of
trial._params, which I believe is a bad practice, since the underline is a sign of "don't use it outside this module".By making tag an optional argument, I can retrieve
trial._paramsby usingget_current_parameter. The main reason I want to do this, instead of refactor it intohas_current_parameteris that, I'm currently implementing something in NAS that needs to retrieve current parameter multiple times. #1432