Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Fix readme 's wrong link #1500

Merged
merged 10 commits into from
Aug 29, 2019
Merged

Fix readme 's wrong link #1500

merged 10 commits into from
Aug 29, 2019

Conversation

rabbit008
Copy link
Contributor

Fix wrong link
Add a repo

README.md Outdated
* Run [ENAS](examples/tuners/enas_nni/README.md) in NNI
* Run [Neural Network Architecture Search](examples/trials/nas_cifar10/README.md) in NNI
* [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) in NNI
* [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) in NNI <br>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@rabbit008 rabbit008 Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok fixed.

README.md Outdated
Besudes, here are some external references (with author's permission) that we would like to share with you.


* [Design and implementation of kubeflow/katib](http://gaocegege.com/Blog/机器学习/katib-new)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design and implementation of kubeflow/katib
Change to: Advisor, NNI, Google Vizier 对比总结 (<Design and implementation of kubeflow/katib> 最后章节

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated
@@ -345,11 +345,18 @@ Before providing your hacks, you can review the [Contributing Instruction](docs/
* [Implement customized TrainingService](docs/en_US/TrainingService/HowToImplementTrainingService.md)


## **External Repositories**
## **External Repositories and References**
Now we have some external usage examples run in NNI from our contributors. Thanks our lovely contributors. And welcome more and more people to join us!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With authors' permission, we listed a set of NNI usage examples and relevant articles.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated
Now we have some external usage examples run in NNI from our contributors. Thanks our lovely contributors. And welcome more and more people to join us!


* Run [ENAS](examples/tuners/enas_nni/README.md) in NNI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Repo - run ENAS with NNI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated
Now we have some external usage examples run in NNI from our contributors. Thanks our lovely contributors. And welcome more and more people to join us!


* Run [ENAS](examples/tuners/enas_nni/README.md) in NNI
* Run [Neural Network Architecture Search](examples/trials/nas_cifar10/README.md) in NNI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated
* Run [ENAS](examples/tuners/enas_nni/README.md) in NNI
* Run [Neural Network Architecture Search](examples/trials/nas_cifar10/README.md) in NNI
* [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) in NNI
* [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) in NNI <br>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated
* [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) in NNI
* [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) in NNI <br>

Besudes, here are some external references (with author's permission) that we would like to share with you.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

README.md Outdated
* **Repo** - Run [Neural Network Architecture Search](examples/trials/nas_cifar10/README.md) with NNI
* **Repo** - [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) with NNI
* **Repo** - [Hyperparameter Tuning for Matrix Factorization](https://github.com/microsoft/recommenders/blob/master/notebooks/04_model_select_and_optimize/nni_surprise_svd.ipynb) with NNI
* **Blog** - Advisor, NNI, Google Vizier ,[Design and implementation of kubeflow/katib](http://gaocegege.com/Blog/机器学习/katib-new)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blog (in Chinese) - AutoML tools (Advisor, NNI and Google Vizier) comparison by @gaocegege - 总结与分析 section of Design and implementation of kubeflow/katib

Copy link

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

* **Repo** - Run [Neural Network Architecture Search](examples/trials/nas_cifar10/README.md) with NNI
* **Repo** - [Automatic Feature Engineering](examples/trials/auto-feature-engineering/README.md) with NNI
* **Repo** - [Hyperparameter Tuning for Matrix Factorization](https://github.com/microsoft/recommenders/blob/master/notebooks/04_model_select_and_optimize/nni_surprise_svd.ipynb) with NNI
* **Blog (in Chinese)** - [AutoML tools (Advisor, NNI and Google Vizier) comparison by @gaocegege - 总结与分析 section of design and implementation of kubeflow/katib](http://gaocegege.com/Blog/机器学习/katib-new)
Copy link

@gaocegege gaocegege Aug 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we only care about the last section, we can use http://gaocegege.com/Blog/%E6%9C%BA%E5%99%A8%E5%AD%A6%E4%B9%A0/katib-new#%E6%80%BB%E7%BB%93%E4%B8%8E%E5%88%86%E6%9E%90

Suggested change
* **Blog (in Chinese)** - [AutoML tools (Advisor, NNI and Google Vizier) comparison by @gaocegege - 总结与分析 section of design and implementation of kubeflow/katib](http://gaocegege.com/Blog/机器学习/katib-new)
* **Blog (in Chinese)** - [AutoML tools (Advisor, NNI and Google Vizier) comparison by @gaocegege - 总结与分析 section of design and implementation of kubeflow/katib](http://gaocegege.com/Blog/%E6%9C%BA%E5%99%A8%E5%AD%A6%E4%B9%A0/katib-new#%E6%80%BB%E7%BB%93%E4%B8%8E%E5%88%86%E6%9E%90)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gaocegege, that's a better fit. @rabbit008 let's use this section link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for @gaocegege ,this pr has been merged. I will request a new branch to fix this link.

@suiguoxin suiguoxin merged commit 4a678c5 into microsoft:v1.0 Aug 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants