This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Resolve comments in PR 1571 #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
reviewed
Oct 9, 2019
| import torch | ||
| import torch.nn.functional as F | ||
| import tensorflow as tf | ||
| import nni.compression.tensorflow as tf_compressor | ||
| import nni.compression.torch as torch_compressor |
There was a problem hiding this comment.
this import order cannot pass pylint
QuanluZhang
approved these changes
Oct 9, 2019
xuehui1991
reviewed
Oct 9, 2019
| @@ -32,8 +32,8 @@ class AGP_Pruner(Pruner): | |||
| """ | |||
| def __init__(self, config_list): | |||
| """ | |||
| Configure Args | |||
| initial_sparsity: | |||
| Configure Args: | |||
There was a problem hiding this comment.
please follow the docstring format like other tuners?
There was a problem hiding this comment.
Updated.
Followed format used in msg_dispatcher.handle_report_metric_data
There was a problem hiding this comment.
I think this format has some differences with the format that we used(We used the format like xgboost). I not sure about that. @leckie-chn
There was a problem hiding this comment.
This does not document the parameter list, instead it documents the fields of one parameter.
added 3 commits
October 9, 2019 16:38
This reverts commit 97a4ed9.
|
Would you add a link to compressor docs in table of contents? Currently, there's no way to see compressor other than searching for it. |
scarlett2018
approved these changes
Oct 14, 2019
leckie-chn
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.