Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Support space in logDir #1694

Merged
merged 10 commits into from
Nov 11, 2019
Merged

Support space in logDir #1694

merged 10 commits into from
Nov 11, 2019

Conversation

SparkSnail
Copy link
Contributor

@SparkSnail SparkSnail commented Nov 3, 2019 •
edited
Loading

liuzhe-lz
liuzhe-lz reviewed Nov 3, 2019
View reviewed changes
src/nni_manager/training_service/local/localTrainingService.ts Outdated
@@ -380,9 +380,9 @@ class LocalTrainingService implements TrainingService {
const envVariables: { key: string; value: string }[] = [
{ key: 'NNI_PLATFORM', value: 'local' },
{ key: 'NNI_EXP_ID', value: this.experimentId },
{ key: 'NNI_SYS_DIR', value: trialJobDetail.workingDirectory },
{ key: 'NNI_SYS_DIR', value: `'${trialJobDetail.workingDirectory}'` },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the value of environment variables should to be quoted.
We should quote them when composing the command, not here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@SparkSnail SparkSnail requested a review from chicm-ms November 5, 2019 04:16
@SparkSnail SparkSnail merged commit 9dec51e into microsoft:master Nov 11, 2019
@SparkSnail SparkSnail mentioned this pull request Nov 11, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@liuzhe-lz liuzhe-lz liuzhe-lz approved these changes

@chicm-ms chicm-ms chicm-ms approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SparkSnail @chicm-ms @liuzhe-lz