This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Show experiment name in nnictl experiment list #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuehui1991
reviewed
Nov 11, 2019
| experiment_information += (EXPERIMENT_DETAIL_FORMAT % (key, experiment_dict[key]['status'], experiment_dict[key]['port'],\ | ||
| experiment_dict[key].get('platform'), experiment_dict[key]['startTime'], experiment_dict[key]['endTime'])) | ||
| experiment_information += EXPERIMENT_DETAIL_FORMAT % (key, | ||
| experiment_dict[key].get('experimentName', 'N/A'), |
There was a problem hiding this comment.
why add a new line in 585
There was a problem hiding this comment.
To make it neat, symmetrical and beautiful.
SparkSnail
reviewed
Nov 11, 2019
tools/nni_cmd/config_utils.py
Outdated
| @@ -81,6 +81,8 @@ def add_experiment(self, expId, port, time, file_name, platform): | |||
| self.experiments[expId]['status'] = 'INITIALIZED' | |||
| self.experiments[expId]['fileName'] = file_name | |||
| self.experiments[expId]['platform'] = platform | |||
| self.experiments[expId]['authorName'] = author_name | |||
There was a problem hiding this comment.
what is author_name used for?
There was a problem hiding this comment.
It's an important metadata. Save it for future use. Also okay to eject. Suggestions?
There was a problem hiding this comment.
Don't know if it will be used in the future, do not suggest to maintain unuseful information in metadata.
SparkSnail
approved these changes
Nov 11, 2019
liuzhe-lz
approved these changes
Nov 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1615. Fix #1628.
Code in
nnictlcould need some refactor. (Many duplicates)