This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Improve logging for standalone mode #1768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
approved these changes
Nov 22, 2019
QuanluZhang
approved these changes
Nov 22, 2019
ultmaster
reviewed
Nov 22, 2019
| @@ -147,9 +148,10 @@ def report_final_result(metric): | |||
| metric: | |||
| serializable object. | |||
| """ | |||
| assert _params is not None, 'nni.get_next_parameter() needs to be called before report_final_result' | |||
| assert _params or trial_env_vars.NNI_PLATFORM is None, \ | |||
There was a problem hiding this comment.
Why _params is not None is now _params?
There was a problem hiding this comment.
I believe _params must not be {} either.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a improved version of PR #1761 , which fixes issue #1740