This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix model compression config validation #2033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanluZhang
approved these changes
Feb 11, 2020
chicm-ms
reviewed
Feb 12, 2020
| if layer.type not in config['op_types']: | ||
| # expand config if key `default` is in config['op_types'] | ||
| if 'op_types' in config and 'default' in config['op_types']: | ||
| config['op_types'].extend(default_layers.weighted_modules) |
There was a problem hiding this comment.
better to remove 'default' after it is expanded.
There was a problem hiding this comment.
I think it is best to just skip checking 'default' in op_types.
chicm-ms
approved these changes
Feb 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix model compression config validation.
rules:
only check op_types and op_names if they are in config file, skip checking otherwise.