This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
fix issue #2091 #2107
Merged
fix issue #2091 #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
approved these changes
Feb 28, 2020
|
I think this PR will induce risk that StackedLSTMCell doesn't work with batch_size > 1. But anyway, we only use this cell when batch_size is 1. |
liuzhe-lz
approved these changes
Feb 28, 2020
|
@marsggbo Can you add a comment suggesting that this cell only works with batch_size = 1? |
|
this cell only works with batch_size = 1 |
|
@marsggbo Yes, I agree. But people who didn't read this PR might not be know that. Better add a note in the code. |
|
thanks @QuanluZhang |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.