This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
make assessors support metric data in dict #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chicm-ms
reviewed
Mar 5, 2020
src/sdk/pynni/nni/utils.py
Outdated
| Incorrect final result: the final result should be float/int, | ||
| or a dict which has a key named "default" whose value is float/int. | ||
| """ | ||
| return [extract_scalar_reward(ele) for ele in trial_history] |
There was a problem hiding this comment.
Looks like the scalar_key should be passed to extract_scalar_reward
chicm-ms
approved these changes
Mar 5, 2020
xuehui1991
approved these changes
Mar 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includeIntermediateResultsis true