This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Show error message when final result doesn't have default metric #2162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Lijiaoa
commented
Mar 18, 2020
Lijiaoa
commented
ultmaster
reviewed
Mar 18, 2020
| } | ||
|
|
||
| getFinalDataFormat = (): void => { | ||
| for(let i = 0; this.state.isilLegalFinal === false; i++){ | ||
| if(TRIALS.succeededTrials()[0] !== undefined && TRIALS.succeededTrials()[0].final !== undefined){ |
There was a problem hiding this comment.
What if we don't have succeeded trials?
There was a problem hiding this comment.
line 64, quit for loop.
There was a problem hiding this comment.
I mean TRIALS.succeddedTrials() will return an empty array, right? What happens to x[0] if x is an empty array?
src/webui/src/App.tsx
Outdated
| } | ||
|
|
||
| getFinalDataFormat = (): void => { | ||
| for(let i = 0; this.state.isilLegalFinal === false; i++){ |
There was a problem hiding this comment.
ilLegal? Really? Should be illegal.
src/webui/src/App.tsx
Outdated
| trialsUpdateBroadcast, | ||
| metricGraphMode, changeMetricGraphMode: this.changeMetricGraphMode | ||
| interval, | ||
| columnList, changeColumn: this.changeColumn, |
There was a problem hiding this comment.
Don't change indentation.
ultmaster
approved these changes
Mar 19, 2020
liuzhe-lz
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.