Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

update gradient_selector dataloader iterator import #2690

Merged
merged 76 commits into from
Jul 31, 2020

Conversation

chicm-ms
Copy link
Contributor

@chicm-ms chicm-ms commented Jul 15, 2020

This PR upgrade gradient_selector torch version from v1.1 to v1.5.

Differences between torch v1.1 and v1.5 related to this PR:

  1. _DataLoaderIter in v1.1 is replaced by _SingleProcessDataLoaderIter and _MultiProcessingDataLoaderIter in v1.5
  2. In v1.5, torch.autograd._make_grads requires shapes of outputs and grads must be consistent, there is no this checking in v1.1:
    https://github.com/pytorch/pytorch/blob/v1.5.0/torch/autograd/__init__.py#L25
  3. timeout needs to be 0 for _SingleProcessDataLoaderIter

chicm-ms added 30 commits August 6, 2019 11:19
Filter prune algo implementation (microsoft#1655)
document the dispatcher working dir (microsoft#1866)
@chicm-ms chicm-ms requested a review from xuehui1991 July 15, 2020 09:59
@chicm-ms chicm-ms requested a review from ultmaster July 15, 2020 10:09
@scarlett2018 scarlett2018 mentioned this pull request Jul 17, 2020
66 tasks
@ultmaster ultmaster mentioned this pull request Jul 17, 2020
@JunweiSUN
Copy link
Contributor

Maybe we need to tell users in the docs that they need to use torch >= 1.5 if they use this selector?

@JunweiSUN JunweiSUN self-requested a review July 29, 2020 03:30
@chicm-ms chicm-ms merged commit d618628 into microsoft:master Jul 31, 2020
@chicm-ms chicm-ms deleted the fix_iterator_import branch October 19, 2020 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants