Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

fix SimulatedAnnealingPruner export mask issue #2736

Merged
merged 1 commit into from
Jul 31, 2020
Merged

fix SimulatedAnnealingPruner export mask issue #2736

merged 1 commit into from
Jul 31, 2020

Conversation

suiguoxin
Copy link
Member

self.modules_wrapper is not properly updated, this cause an error when 'export_model' is called

@QuanluZhang
Copy link
Contributor

self.modules_wrapper is not properly updated, this cause an error when 'export_model' is called

could you describe the error?

@ultmaster ultmaster requested review from colorjam and chicm-ms July 27, 2020 02:46
@suiguoxin
Copy link
Member Author

self.modules_wrapper is not properly updated, this cause an error when 'export_model' is called

could you describe the error?

A all-one mask will be exported because self.modules_wrapper is not updated, self.modules_wrapper is needed in the function export_model().

Pruner.compress() works just fine before this fix because self.bound_model is correctly updated.

@ultmaster ultmaster merged commit bbcb167 into microsoft:master Jul 31, 2020
@suiguoxin suiguoxin deleted the sapruner branch August 1, 2020 06:56
@suiguoxin suiguoxin mentioned this pull request Aug 5, 2020
Closed
@ultmaster ultmaster mentioned this pull request Aug 14, 2020
Closed
66 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chicm-ms chicm-ms chicm-ms approved these changes

@QuanluZhang QuanluZhang QuanluZhang approved these changes

@colorjam colorjam Awaiting requested review from colorjam

Assignees
No one assigned
Labels
model compression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suiguoxin @QuanluZhang @chicm-ms @ultmaster