This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Hotfix installation problem on Windows without conda/venv #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkSnail
reviewed
Aug 24, 2020
| ''' | ||
| for sitepackage in sitepackages: | ||
| for path in [Path(sitepackage).parents[2], Path(sitepackage)]: | ||
| if (path / 'nni' / 'main.js').is_file(): |
There was a problem hiding this comment.
what is value of path / 'nni' / 'main.js'?
There was a problem hiding this comment.
A Path object referring to main.js file in nni folder in path. It's expected to be C:\Python38\nni\main.js.
chicm-ms
approved these changes
Aug 24, 2020
SparkSnail
approved these changes
Aug 24, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows
site.getsitepackages()[0]can either be the base directory likeC:\Python38, orsite-packages. So all items in that list need to be checked.The ideal solution is to find a reliable resource packaging machanism.
data_filesis not designed for this use case.