This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Add nnictl ut #2912
Merged
Add nnictl ut #2912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master
merge master
merge master
merge master
merge master
merge master
merge master
Chinese translation (microsoft#2458)
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
merge master
ultmaster
reviewed
Sep 21, 2020
| @@ -0,0 +1,50 @@ | |||
|
|
|||
There was a problem hiding this comment.
extra line (or missing license)
| responses.GET, 'http://localhost:8080/api/v1/nni/trial-jobs', | ||
| json=[{"id":"GPInz","status":"SUCCEEDED","hyperParameters":["{\"parameter_id\":0, \ | ||
| \"parameter_source\":\"algorithm\",\"parameters\":{\"C\":0.8748364659110364, \ | ||
| \"kernel\":\"linear\",\"degree\":1,\"gamma\":0.040451413392113666,\"coef0 \":0.040353532973662266}, \ |
There was a problem hiding this comment.
I remember the extra space in coef0 has been removed in another PR?
chicm-ms
reviewed
Sep 21, 2020
tools/nni_cmd/config_utils.py
Outdated
| @@ -9,8 +9,8 @@ | |||
|
|
|||
| class Config: | |||
| '''a util class to load and save config''' | |||
| def __init__(self, file_path): | |||
| config_path = os.path.join(NNICTL_HOME_DIR, str(file_path)) | |||
| def __init__(self, file_path, home_dir = NNICTL_HOME_DIR): | |||
There was a problem hiding this comment.
better to remove spaces around = for default values.
There was a problem hiding this comment.
updated, seems pylint didn't check this
chicm-ms
reviewed
Sep 21, 2020
chicm-ms
reviewed
Sep 21, 2020
chicm-ms
reviewed
Sep 21, 2020
chicm-ms
reviewed
Sep 21, 2020
ultmaster
approved these changes
Sep 25, 2020
chicm-ms
reviewed
Sep 26, 2020
tools/nni_cmd/config_utils.py
Outdated
| def __init__(self): | ||
| os.makedirs(NNICTL_HOME_DIR, exist_ok=True) | ||
| self.experiment_file = os.path.join(NNICTL_HOME_DIR, '.experiment') | ||
| def __init__(self, home_dir = NNICTL_HOME_DIR): |
chicm-ms
approved these changes
Sep 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.