This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Integration test #3088
Merged
Integration test #3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkSnail
reviewed
Nov 23, 2020
| @@ -73,15 +75,15 @@ RUN python3 -m pip --no-cache-dir install pandas==0.23.4 lightgbm==2.2.2 | |||
| # | |||
| # Install NNI | |||
| # | |||
| RUN python3 -m pip --no-cache-dir install nni | |||
| COPY dist/nni-${NNI_RELEASE}-py3-none-manylinux1_x86_64.whl . | |||
There was a problem hiding this comment.
why change the install method?
There was a problem hiding this comment.
The Dockerfile might be used by two category of users:
- Customers
- NNI devs
For customers, if they want NNI image of latest release version, they can simply pull from docker hub. So if a customer uses Dockerfile, they are most likely using a modified NNI package, in which case they won't want latest NNI from pypi.
For us, we use pipelines to build and upload docker images. The release pipeline always builds docker image together with wheel, so there is no benefit to push then pull. It can use the same wheel file for pypi and docker.
chicm-ms
approved these changes
Nov 26, 2020
SparkSnail
approved these changes
Dec 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending tasks: (in future PR)