Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

config refactor stage 0 - new base class #4303

Merged
merged 4 commits into from
Nov 15, 2021

Conversation

liuzhe-lz
Copy link
Contributor

@liuzhe-lz liuzhe-lz commented Nov 10, 2021

Description

The first version of ConfigBase was too magic that nobody can understand how to use it.
This refactored version has 4 major improvements:

  1. The API is much more intuitive
  2. Support validating data type
  3. Handle base path transparently, so it no longer pollutes __init__()'s args
  4. Automatically unpack nested config, so most subclasses won't need to override __init__()

Note that this PR is merging to dev-config branch, not master.

Checklist

  • test case
  • doc

How to test

Should be tested together with other configure refactor PRs.

@liuzhe-lz liuzhe-lz changed the title configure refactor stage 0 - new base class config refactor stage 0 - new base class Nov 10, 2021
@liuzhe-lz liuzhe-lz mentioned this pull request Nov 12, 2021
86 tasks
nni/experiment/config/base.py Outdated Show resolved Hide resolved
@liuzhe-lz liuzhe-lz merged commit 80d518a into microsoft:dev-config Nov 15, 2021
@liuzhe-lz liuzhe-lz deleted the dev-config-s0 branch November 15, 2021 03:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants