This repository has been archived by the owner on Sep 18, 2024. It is now read-only.
Retiarii serializer user experience improvements #4437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ultmaster
requested review from
QuanluZhang and
liuzhe-lz
and removed request for
QuanluZhang
QuanluZhang
reviewed
Dec 30, 2021
nni/retiarii/evaluator/functional.py
Outdated
| @@ -26,6 +26,7 @@ def _load(ir): | |||
|
|
|||
| def _dump(self): | |||
| return { | |||
| 'type_name': self.__class__, | |||
There was a problem hiding this comment.
what is the type of self.__class__? is it safe to dump this self.__class__ object and load it in another environment (e.g., another machine)?
There was a problem hiding this comment.
Its type is "type". nni.dump and nni.load will handle the serialization of a "type" object.
- If we can get its path, we dump it into a path. e.g.,
torch.nn.Conv2d. - Otherwise, we dump it into a binary. e.g., class defined in a jupyter notebook.
To simplify unit-tests, I also allow subclass class name here. But actually it's not used in practice.
There was a problem hiding this comment.
Since it's a type object, why the key is called "type name"?
There was a problem hiding this comment.
Good question. I copied from operation.py. Let me fix it.
QuanluZhang
approved these changes
Dec 31, 2021
liuzhe-lz
approved these changes
Jan 4, 2022
86 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
model_wrappedin Retiarii experiment.Checklist
test caseHow to test
Same as #4390.