Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

update Chinese file path as en_US #764

Merged
merged 1,413 commits into from
Feb 26, 2019

Conversation

squirrelsc
Copy link
Member

No description provided.

Copy link
Contributor

@leckie-chn leckie-chn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think most of the README_zh_CN.md outside of docs/zh_CN folder can be removed. They are either duplicate with the ones inside docs/zh_CN, such as examples/assessors/README_zh_CN.md (dup with Customize_Assessor); or not useful for users, such as deployment/docker/README_zh_CN.md. As you mentioned yourself, we can't create README_locale.md for every language.
So I suggest that you delete all the _zh_CN.md outside docs/zh_CN except README_zh_CN.md at the root.
For those docs that you think worth translating they will be moved under docs folder.

@squirrelsc
Copy link
Member Author

They are mapping with en_us version, when en_us version is removed, they can be removed together.

@leckie-chn
Copy link
Contributor

They are mapping with en_us version, when en_us version is removed, they can be removed together.

@squirrelsc could you please just delete the mapping? After all, some of the documents is for developers, such as deployment/docker/README.md, which do not need a Chinese version.

@squirrelsc squirrelsc merged commit fbf4668 into microsoft:master Feb 26, 2019
SparkSnail added a commit to SparkSnail/nni that referenced this pull request Feb 26, 2019
update Chinese file path as en_US (microsoft#764)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants