Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Matmul from broadcast op #129

Merged
merged 1 commit into from
Jun 17, 2020
Merged

Remove Matmul from broadcast op #129

merged 1 commit into from
Jun 17, 2020

Conversation

jiafatom
Copy link
Contributor

@jiafatom jiafatom commented Jun 17, 2020 •
edited
Loading

Some keras2onnx tests fails, because when we pass Matmul op, we try to broadcast the initializer, but it seems the current broadcast does not work for Matmul.

@jiafatom jiafatom requested a review from wenbingl June 17, 2020 21:46
wenbingl
wenbingl approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@wenbingl wenbingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

matmul not supporting broadcasting?

@jiafatom
Copy link
Contributor Author

matmul not supporting broadcasting?

It does not say support broadcasting. At least not working the way like other broadcast ops.

@jiafatom jiafatom merged commit c5c29c9 into microsoft:master Jun 17, 2020
@jiafatom jiafatom deleted the matmul_not branch June 17, 2020 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenbingl wenbingl wenbingl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiafatom @wenbingl