Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip PushTranspose when broadcast has two un-init inputs #144

Merged
merged 3 commits into from
Sep 4, 2020

Conversation

jiafatom
Copy link
Contributor

@jiafatom jiafatom commented Sep 4, 2020

Converting scSEUnet, hit a broadcast node Mul Mul4, it has two inputs, one has dimension 4 the other dimension 2 from Sigmoid. There is broadcasting there, no initializer. We don't have node output shape so we don't know this dimension 2. Current code handles as if it is same dimension, so adding a Transpose with 4D perm for Sigmoid output. This is not correct.
This PR skip PushTransposeSolution for this case.

@jiafatom jiafatom requested a review from wenbingl September 4, 2020 20:51
@jiafatom jiafatom merged commit be177b5 into microsoft:master Sep 4, 2020
@jiafatom jiafatom deleted the broadcast_two branch September 4, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants