Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OneBranchPipeline.yml file #226

Merged
merged 19 commits into from
Jul 12, 2022
Merged

Update OneBranchPipeline.yml file #226

merged 19 commits into from
Jul 12, 2022

Conversation

xiaowuhu
Copy link
Collaborator

@xiaowuhu xiaowuhu commented Jun 29, 2022

Signed-off-by: xiaowuhu [email protected]

add variable ob_outputDirectory so the pipeline can run with the predefined template.

xiaowuhu added 2 commits June 29, 2022 19:08
Signed-off-by: xiaowuhu <[email protected]>

change the version number, just for testing the OneBranch pipeline, to check if it can work.
Signed-off-by: xiaowuhu <[email protected]>

add variable ob_outputDirectory so the pipeline can run with the predefined template.
@xiaowuhu xiaowuhu changed the title Update __init__.py Update OneBranchPipeline.yml file Jun 29, 2022
displayName: 'Enable debug output'
type: boolean
default: false
trigger: none
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider having two files:
.azure-pipelines/OneBranchPipeline-Official.yml and .azure-pipelines/OneBranchPipeline-PullRequest.yml.

At least you need one official pipeline

@snnn
Copy link
Member

snnn commented Jul 8, 2022

Copy link
Member

@snnn snnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But please also create another one for an official pipeline. You may just copy this file and in the line 30 change the base template .

xiaowuhu added 6 commits July 11, 2022 16:28
Signed-off-by: xiaowuhu <[email protected]>

change trigger from none to master, and change the template from unofficial to Official
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu <[email protected]>
@xiaowuhu xiaowuhu merged commit 0a401de into master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants