-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OneBranchPipeline.yml file #226
Conversation
Signed-off-by: xiaowuhu <[email protected]> change the version number, just for testing the OneBranch pipeline, to check if it can work.
Signed-off-by: xiaowuhu <[email protected]> add variable ob_outputDirectory so the pipeline can run with the predefined template.
displayName: 'Enable debug output' | ||
type: boolean | ||
default: false | ||
trigger: none |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider having two files:
.azure-pipelines/OneBranchPipeline-Official.yml and .azure-pipelines/OneBranchPipeline-PullRequest.yml.
At least you need one official pipeline
I scheduled a run for your change: https://aiinfra.visualstudio.com/Lotus/_build/results?buildId=217604&view=results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But please also create another one for an official pipeline. You may just copy this file and in the line 30 change the base template .
Signed-off-by: xiaowuhu <[email protected]> change trigger from none to master, and change the template from unofficial to Official
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu <[email protected]>
Signed-off-by: xiaowuhu [email protected]
add variable ob_outputDirectory so the pipeline can run with the predefined template.