Skip to content

Commit

Permalink
Merged PR 3985217: add onecoreuap_apiset.lib in order to avoid linkin…
Browse files Browse the repository at this point in the history
…g against kernel32.lib etc (#2346)

add onecoreuap_apiset.lib in order to avoid linking against kernel32.lib etc and violating our OS layering requirements.

We linked against onecoreuap_apiset.lib in VB so we will continue doing this, but I am still unsure why not to link against onecore instead since that is where we ship. However, since Sheil is the owner of this code we will wait to discuss with him before changing anything.
  • Loading branch information
martinb35 authored Nov 7, 2019
1 parent 7390b64 commit b94ae8e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion cmake/winml.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -462,6 +462,7 @@ if("${CMAKE_BUILD_TYPE}" STREQUAL "Debug")
endif("${CMAKE_BUILD_TYPE}" STREQUAL "Debug")

# Link libraries
target_link_libraries(winml_dll PRIVATE windowsapp.lib)
target_link_libraries(winml_dll PRIVATE libprotobuf)
target_link_libraries(winml_dll PRIVATE onnx)
target_link_libraries(winml_dll PRIVATE onnxruntime_common)
Expand All @@ -476,11 +477,11 @@ target_link_libraries(winml_dll PRIVATE onnxruntime_util)
target_link_libraries(winml_dll PRIVATE onnx_proto)
target_link_libraries(winml_dll PRIVATE re2)
target_link_libraries(winml_dll PRIVATE wil)
target_link_libraries(winml_dll PRIVATE windowsapp.lib)
target_link_libraries(winml_dll PRIVATE winml_lib_api)
target_link_libraries(winml_dll PRIVATE winml_lib_core)
target_link_libraries(winml_dll PRIVATE winml_lib_image)
target_link_libraries(winml_dll PRIVATE winml_lib_telemetry)
target_link_libraries(winml_dll PRIVATE onecoreuap_apiset.lib)
target_link_libraries(winml_dll PRIVATE ${DBGHELP})

# 1 of 3 projects that fail in link with 'failed to do memory mapped file I/O' (Only release)
Expand Down

0 comments on commit b94ae8e

Please sign in to comment.