-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional python requirements #11522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you need to add its license at ThirdPartyNotice.txt
Refer to the commit below as an example
commit ef20efe
Author: Thiago Crepaldi [email protected]
Date: Mon Aug 17 15:03:54 2020 -0700
Register cerberus license into ThirdPartyNotices.txt (#4828)
You also have to ensure the Governance Compliance component check is passing (the CI does not fail when an issue is found, but it is logged instead)
It's used by some of the python code in the package, e.g., https://github.com/microsoft/onnxruntime/blob/0292356bd7ce5b379be8ee9820bfbf4fd321ebc5/onnxruntime/python/tools/transformers/optimizer.py#L25
1721810
to
adb32a1
Compare
Thanks @thiagocrepaldi .
We're not distributing this software ourselves (e.g. by including any part of it in our packages), just declaring deps, so I don't think so.
I don't see that in the list of checks. Do I need to trigger it manually? How? |
@snnn does the file need to be named as requirements.txt (without the |
AFAIK
|
Just talked to @snnn and he said |
We use this file to generate a requirements.txt in the build folder. I believe component governance scans build folder as well. So, it's fine. |
Can someone please approve or critique? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update Python dependencies following upstream [1]. * Rebase patches for devendoring after upstream changes [2]. * Avoid wheel.vendored, which is needed since [3] while devendored in Arch [4]. [1] microsoft/onnxruntime#11522 [2] microsoft/onnxruntime#11146 [3] microsoft/onnxruntime#11834 [4] archlinux/svntogit-community@e691288
* Update Python dependencies following upstream [1]. * Rebase patches for devendoring after upstream changes [2]. * Avoid wheel.vendored, which is needed since [3] while devendored in Arch [4]. [1] microsoft/onnxruntime#11522 [2] microsoft/onnxruntime#11146 [3] microsoft/onnxruntime#11834 [4] archlinux/svntogit-community@e691288
These are used by some of the python code in the package, e.g.,
onnxruntime/onnxruntime/python/tools/transformers/optimizer.py
Line 25 in 0292356
onnxruntime/onnxruntime/python/tools/symbolic_shape_infer.py
Line 10 in c8270c2
onnxruntime/onnxruntime/python/tools/transformers/torch_onnx_export_helper.py
Line 9 in 0292356