Fix lgtm C++ error #13613
Merged
Fix lgtm C++ error #13613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! We can take this and use it for migration to CodeQL |
henrywu2019
pushed a commit
to henrywu2019/onnxruntime
that referenced
this pull request
Dec 21, 2022
### Description <!-- Describe your changes. --> ### Motivation and Context Recently, every change in C/C++ code has the exception as below ``` [2022-11-10 04:36:05] [build-stderr] CMake Error at CMakeLists.txt:5 (cmake_minimum_required): [2022-11-10 04:36:05] [build-stderr] CMake 3.24 or higher is required. You are running version 3.23.1 ``` https://lgtm.com/projects/g/microsoft/onnxruntime/logs/rev/pr-9c39e0fe82768b017af09118af7344a9703317a5/lang:cpp/stage:Build%20merge_d70f6e7a151e1fea8003b81a4e6d6aa6a80a788d ### Verification We could see the test commit in my branch passed. Once the PR is merged, master build check would pass too. <img width="767" alt="image" src="https://user-images.githubusercontent.com/16190118/201086512-25ea69e7-6fe5-4939-b557-b3468428d363.png">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Recently, every change in C/C++ code has the exception as below
https://lgtm.com/projects/g/microsoft/onnxruntime/logs/rev/pr-9c39e0fe82768b017af09118af7344a9703317a5/lang:cpp/stage:Build%20merge_d70f6e7a151e1fea8003b81a4e6d6aa6a80a788d
Verification
We could see the test commit in my branch passed.
Once the PR is merged, master build check would pass too.