Introducing ORTPipelineModule - DeepSpeed Parallel Pipeline Support. #20287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
orttraining/orttraining/python/training/ortmodule/pipe/_ort_pipeline_module.py
Fixed
Show fixed
Hide fixed
wschin
reviewed
Apr 17, 2024
wschin
reviewed
Apr 17, 2024
wschin
reviewed
Apr 17, 2024
wschin
reviewed
Apr 17, 2024
orttraining/orttraining/python/training/ortmodule/experimental/pipe/_ort_pipeline_module.py
Show resolved
Hide resolved
wschin
reviewed
Apr 17, 2024
orttraining/orttraining/python/training/ortmodule/experimental/pipe/_ort_pipeline_module.py
Show resolved
Hide resolved
wschin
reviewed
Apr 17, 2024
orttraining/orttraining/python/training/ortmodule/experimental/pipe/_ort_pipeline_module.py
Show resolved
Hide resolved
wschin
reviewed
Apr 17, 2024
orttraining/orttraining/python/training/ortmodule/experimental/pipe/_ort_pipeline_module.py
Outdated
Show resolved
Hide resolved
wschin
reviewed
Apr 17, 2024
orttraining/orttraining/python/training/ortmodule/experimental/pipe/_ort_pipeline_module.py
Show resolved
Hide resolved
wschin
previously approved these changes
Apr 17, 2024
wschin
approved these changes
Apr 17, 2024
|
Thanks for the review |
TedThemistokleous
pushed a commit
to TedThemistokleous/onnxruntime
that referenced
this pull request
May 7, 2024
…icrosoft#20287) ### Description Introducing a new class ORTPipelineModule to handle wrapping layers in DeepSpeed pipeline parallel. ### Motivation and Context To support pipeline parallelism on ORTModule. This PR will include an initial support of deepspeed Pipeline parallelism. - [x] Support Pipeline parallel where layers are nn Modules in Sequential. - [ ] Support LayerSpec and TiedLayerSpec - [ ] Enable partitioning to accept List - [ ] Full-GPU Graph Consolidation - [ ] Subgraph Merging for Inference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a new class ORTPipelineModule to handle wrapping layers in DeepSpeed pipeline parallel.
Motivation and Context
To support pipeline parallelism on ORTModule.
This PR will include an initial support of deepspeed Pipeline parallelism.