Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update C# test projects #21631

Merged
merged 7 commits into from
Sep 4, 2024
Merged

Conversation

skottmckay
Copy link
Contributor

Description

Update various test projects to .net8 from EOL frameworks.
Replace the Xamarin based Android and iOS test projects with a MAUI based project that uses .net 8.
Add new CoreML flags to C# bindings

Motivation and Context

Remove usage of EOL frameworks.

Replace the Xamarin based Android and iOS test projects with a MAUI based project that uses .net 8.
Add new CoreML flags to C# bindings
@skottmckay skottmckay requested a review from a team as a code owner August 6, 2024 05:02
@skottmckay
Copy link
Contributor Author

skottmckay commented Aug 28, 2024

@snnn @mszhanyi can we add .net8 to the onnxruntime-Ubuntu2204-AMD-CPU and onnxruntime-Win-CPU-2022 images?

@snnn
Copy link
Member

snnn commented Aug 28, 2024

@snnn @mszhanyi can we add .net8 to the onnxruntime-Ubuntu2204-AMD-CPU and onnxruntime-Win-CPU-2022 images?

Sure. You mean .net 8 sdk?

@snnn
Copy link
Member

snnn commented Aug 28, 2024

I believe we have multiple SDKs in /usr/share/dotnet/sdk. You may need to use this ADO task to choose the version

@skottmckay skottmckay requested a review from edgchen1 September 4, 2024 05:35
@skottmckay skottmckay merged commit 44fc7b4 into main Sep 4, 2024
97 checks passed
@skottmckay skottmckay deleted the skottmckay/UpdateCSharpTestProjects branch September 4, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants