Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebNN EP] Fix issues of GRU operator #22123

Merged
merged 6 commits into from
Nov 13, 2024
Merged

[WebNN EP] Fix issues of GRU operator #22123

merged 6 commits into from
Nov 13, 2024

Conversation

miaobin
Copy link
Contributor

@miaobin miaobin commented Sep 18, 2024

Description

This PR fixes the spelling of the key value of the GRU operator in the map in the GetSupportedNodes function (Gru -> GRU) and removes the data type check for the fifth input (sequence_lens) of the GRU operator.

PTAL, thanks!

Honry
Honry approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Honry
Honry approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@Honry Honry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@miaobin
Copy link
Contributor Author

miaobin commented Oct 28, 2024

@fdwr PTAL, thanks a lot!

@fdwr fdwr requested review from fdwr and guschmue October 31, 2024 00:53
fdwr
fdwr previously approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, dropped this until Honry reminded me today. 👀

onnxruntime/core/providers/webnn/builders/impl/gru_op_builder.cc Show resolved Hide resolved
@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 12, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr
Copy link
Contributor

fdwr commented Nov 13, 2024

/azp run Python format, orttraining-linux-ci-pipeline

@microsoft microsoft deleted a comment from azure-pipelines bot Nov 13, 2024
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft microsoft deleted a comment from azure-pipelines bot Nov 13, 2024
@miaobin
Copy link
Contributor Author

miaobin commented Nov 13, 2024

Rebased this CL and please take another look, thanks a lot! @fdwr

fdwr
fdwr approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks.

@fdwr
Copy link
Contributor

fdwr commented Nov 13, 2024

/azp run ONNX Runtime Web CI Pipeline,Windows GPU CI Pipeline,Linux Android Emulator QNN CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 13, 2024

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 13, 2024

/azp run Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline

@fdwr
Copy link
Contributor

fdwr commented Nov 13, 2024

/azp run Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,Windows x64 QNN CI Pipeline,Big Models

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@fdwr fdwr merged commit a15381d into microsoft:main Nov 13, 2024
75 checks passed
ishwar-raut1 pushed a commit to ishwar-raut1/onnxruntime that referenced this pull request Nov 19, 2024
@miaobin
[WebNN EP] Fix issues of GRU operator (microsoft#22123)
0d25e36 
### Description
This PR fixes the spelling of the key value of the GRU operator in the
map in the `GetSupportedNodes` function (Gru -> GRU) and removes the
data type check for the fifth input (sequence_lens) of the GRU operator.

PTAL, thanks!
guschmue pushed a commit that referenced this pull request Dec 2, 2024
@miaobin @guschmue
[WebNN EP] Fix issues of GRU operator (#22123)
5a4d294 
### Description
This PR fixes the spelling of the key value of the GRU operator in the
map in the `GetSupportedNodes` function (Gru -> GRU) and removes the
data type check for the fifth input (sequence_lens) of the GRU operator.

PTAL, thanks!
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@miaobin @ankitm3k
[WebNN EP] Fix issues of GRU operator (microsoft#22123)
b7e9d4d 
### Description
This PR fixes the spelling of the key value of the GRU operator in the
map in the `GetSupportedNodes` function (Gru -> GRU) and removes the
data type check for the fifth input (sequence_lens) of the GRU operator.

PTAL, thanks!
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@miaobin @ankitm3k
[WebNN EP] Fix issues of GRU operator (microsoft#22123)
4192974 
### Description
This PR fixes the spelling of the key value of the GRU operator in the
map in the `GetSupportedNodes` function (Gru -> GRU) and removes the
data type check for the fifth input (sequence_lens) of the GRU operator.

PTAL, thanks!
ankitm3k pushed a commit to intel/onnxruntime that referenced this pull request Dec 11, 2024
@miaobin @ankitm3k
[WebNN EP] Fix issues of GRU operator (microsoft#22123)
255e4bb 
### Description
This PR fixes the spelling of the key value of the GRU operator in the
map in the `GetSupportedNodes` function (Gru -> GRU) and removes the
data type check for the fifth input (sequence_lens) of the GRU operator.

PTAL, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

@Honry Honry Honry approved these changes

@guschmue guschmue Awaiting requested review from guschmue

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miaobin @fdwr @Honry