Fix Where op type reduction processing #9033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
approved these changes
Sep 11, 2021
wangyems
pushed a commit
that referenced
this pull request
Sep 14, 2021
* Update type reduction script to track Where Op's second input type. * Clean up op_kernel_type_control.h includes. * Use more maintainable include.
wangyems
added a commit
that referenced
this pull request
Sep 16, 2021
* Adding async fetching for webgl backend (#8951) * Adding async fetching for webgl backend * fix PR comments and CI failure. * fixing a bug * adding a flag * Enable linking in exception throwing support library when build onnxruntime wasm. (#8973) * Enable linking in exception throwing support library when build onnxruntime webassembly containing onnxruntime-extensions. * Add flag in build.py to enable linking exceptions throwing library. * Update onnxruntime-extensions document and bind custom_ops build flag with use_extensions. * Update doc. * Update cgmanifest.json. Co-authored-by: Zuwei Zhao <[email protected]> * Remove document text from error message in a couple of ops (#9003) * do not add pkg wheel entry to the index html file if it already exists (#9004) * do not add pkg wheel entry to the index html file if it already exists * [js/web] fix ort web e2e test (#9025) * Fix cmake POWER10 detection Recent commit 60c98a8 changed variable mlas_common_srcs which affects POWER10 detection. * Fix Where op type reduction processing (#9033) * Update type reduction script to track Where Op's second input type. * Clean up op_kernel_type_control.h includes. * Use more maintainable include. * Fix ROCm wheels CI pipeline break by installing latest protobuf from source (#9047) * install protobuf from source * fix rm command in Dockerfile * fix options on rm command * fix cd into protobuf source directory * try again * remove strip step * debug list the files * ls on /usr * more debug * more debug * adjust LD_LIBRARY_PATH * try remove protobuf before ORT build * [js/web] a bugfix and add tests for wasm proxy worker (#9048) * [js/web] add tests for wasm proxy worker * fix script src override * Set onnxruntime_DISABLE_RTTI to default OFF (#9049) Co-authored-by: Du Li <[email protected]> Co-authored-by: Zuwei Zhao <[email protected]> Co-authored-by: Zuwei Zhao <[email protected]> Co-authored-by: Hariharan Seshadri <[email protected]> Co-authored-by: liqun Fu <[email protected]> Co-authored-by: Yulong Wang <[email protected]> Co-authored-by: Rajalakshmi Srinivasaraghavan <[email protected]> Co-authored-by: Edward Chen <[email protected]> Co-authored-by: Suffian Khan <[email protected]> Co-authored-by: Changming Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Where op's first parameter is always boolean, so we should track the type of the remaining parameters for type reduction. The default op type reduction processing considers the first parameter.
In this change:
Motivation and Context
Fix issue where the wrong input was being matched when excluding typed kernel implementations.