Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TDX VMs with hyperthreading getting incorrect thread count #481

Closed
vibhutet opened this issue Dec 13, 2024 · 1 comment
Closed

TDX VMs with hyperthreading getting incorrect thread count #481

vibhutet opened this issue Dec 13, 2024 · 1 comment
Labels
bug Something isn't working tdx TDX specific bugs or features
Milestone
OpenHCL support f...

Comments

@vibhutet
Copy link
Contributor

vibhutet commented Dec 13, 2024 •
edited
Loading

In Windows TDX VMs, the powershell command gwmi Win32_Processor | fl * is yeilding incorrect values for ThreadCount and NumberOfEnabledCore when hyperthreading is enabled.
The topology builder needs a correction in how vps_per_socket are determined from Cpuid leaf Cache Parameters (0x4). Additionally, the kernel forwards most CPUID intercepts received in #VE handler to the user mode without any particular handling. Hence the topology builder is unable to determine the topology from Cpuid leaf Extended Topology Enumeration (0xB).
@vibhutet
Copy link
Contributor Author

Should the #VE handler be updated to retrieve the topology from ExtendedTopologyEnumeration?

@vibhutet vibhutet mentioned this issue Dec 18, 2024
Merged
@cperezvargas cperezvargas added bug Something isn't working tdx TDX specific bugs or features labels Dec 20, 2024
smalis-msft pushed a commit that referenced this issue Jan 7, 2025
@vibhutet
Updated topology builder with correct vps_per_socket calculation (#532)
e40801c 
Implements issue: [TDX VMs with hyperthreading getting incorrect thread
count #481](#481)
smalis-msft pushed a commit to smalis-msft/openvmm that referenced this issue Jan 8, 2025
@vibhutet @smalis-msft
Updated topology builder with correct vps_per_socket calculation (mic…
c404e86 
…rosoft#532)

Implements issue: [TDX VMs with hyperthreading getting incorrect thread
count microsoft#481](microsoft#481)
@smalis-msft smalis-msft mentioned this issue Jan 8, 2025
Merged
smalis-msft added a commit that referenced this issue Jan 8, 2025
@smalis-msft @vibhutet
cherry-pick: Updated topology builder with correct vps_per_socket cal…
2b4f5ae 
…culation (#532) (#629)

Implements issue: [TDX VMs with hyperthreading getting incorrect thread
count #481](#481)

Co-authored-by: Tejaswini Vibhute <[email protected]>
@vibhutet vibhutet mentioned this issue Feb 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working tdx TDX specific bugs or features
Projects
None yet
Milestone
OpenHCL support for the GA of TDX CVM...
Development

No branches or pull requests
2 participants
@vibhutet @cperezvargas