Begin working towards Rust 2024 compatibility #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daprilik
reviewed
Nov 11, 2024
daprilik
reviewed
Nov 11, 2024
daprilik
reviewed
Nov 11, 2024
smalis-msft
commented
Nov 12, 2024
daprilik
approved these changes
Nov 12, 2024
benhillis
pushed a commit
to benhillis/openvmm
that referenced
this pull request
Jan 15, 2025
This PR fixes up the easy issues with Rust 2024 compatibility and enables the lint for it. However it also scopes out some allows for the things that need some more work and focus. microsoft#288 is tracking them. Changes in this PR: - extern blocks are now unsafe - `gen` is becoming a reserved keyword, rename variables - mark unsafe attributes other than linkme's - resolve the ambiguity of `fn poll` in VmbusSerialDriver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes up the easy issues with Rust 2024 compatibility and enables the lint for it. However it also scopes out some allows for the things that need some more work and focus. #288 is tracking them.
Changes in this PR:
genis becoming a reserved keyword, rename variablesfn pollin VmbusSerialDriver