Replace LapicState's three bools with the enum they represent #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarks
reviewed
Dec 16, 2024
jstarks
reviewed
Dec 16, 2024
jstarks
reviewed
Dec 16, 2024
jstarks
reviewed
Dec 17, 2024
smalis-msft
force-pushed
the
three-bools-too-many
branch
from
efc8f95 to
62baa4a
Compare
jstarks
approved these changes
Dec 17, 2024
jaredwhitedev
added a commit
that referenced
this pull request
Jan 7, 2025
…t offloading (#616) flowey: Remove kernel version from step name CP from (#617) No changes. Update OHCL kernel to 6.6.63.1 CP from (#568) YAML change in original commit ignored. No other changes. TDX: Add support for kernel interrupt offloading CP from (#124) Changed to use `LapicState`'s `halted`, `idle`, `startup_suspend` fields instead of the `MpState` enum, as (#470) is not present in this branch. --------- Co-authored-by: Ben Hillis <[email protected]> Co-authored-by: Ben Hillis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some weirdness around things like "can you be idle and halted at the same time?". This needs some very careful review, as it does change some state transitions slightly.